CircleCI validation of release using templates #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
oorestisime
reviewed
Mar 28, 2019
There was a problem hiding this comment.
Heya,
Added 2 comments on the implementation.
Generally speaking, I get this is important but i kind of feel it should wait the monorepo. We should probably have more templates, build the patterns that have a real value and part of me feels that this kind of testing should happen on each PR not before the release.
oorestisime
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds a new run command that validates a newly published release
Where should the reviewer start?
.circleci/config.yml
What testing has been done on this PR?
running the new template that is used for the validation
How should this be manually tested?
publishing
What are the relevant issues?
#2978
Screenshots (if appropriate)
Do the grommet docs need to be updated?
not really, I've updated relevant README files.
Should this PR be mentioned in the release notes?
no
Is this change backwards compatible or is it a breaking change?
backwards compatible