Navigation Menu

Skip to content

Commit

Permalink
test: use Fluent::Test::Driver::Output for v0.14
Browse files Browse the repository at this point in the history
  • Loading branch information
kenhys committed Apr 11, 2017
1 parent df4e4da commit 4b581bd
Showing 1 changed file with 15 additions and 11 deletions.
26 changes: 15 additions & 11 deletions test/test_output.rb
Expand Up @@ -23,6 +23,7 @@

require "fluent/test"
require "fluent/plugin/out_groonga"
require "fluent/test/driver/output"

require "http_parser"

Expand All @@ -34,8 +35,7 @@ def setup_fluent

private
def create_driver(tag)

This comment has been minimized.

Copy link
@cosmo0920

cosmo0920 Apr 11, 2017

Contributor

Can we omit tag argument and replace with default_tag: in driver#run?

driver = Fluent::Test::BufferedOutputTestDriver.new(Fluent::Plugin::GroongaOutput,
tag)
driver = Fluent::Test::Driver::Output.new(Fluent::Plugin::GroongaOutput)
driver.configure(configuration)
driver
end
Expand Down Expand Up @@ -100,8 +100,9 @@ def test_basic_command
@response_body = JSON.generate([[0, 0.0, 0.0], true])
driver = create_driver("groonga.command.table_create")
time = Time.parse("2012-10-26T08:45:42Z").to_i

This comment has been minimized.

Copy link
@cosmo0920

cosmo0920 Apr 11, 2017

Contributor

We can use event_time test helper as follows:

require 'fluent/test/helpers'

class GroongaOutputTest < Test::Unit::TestCase
  include Fluent::Test::Helpers 
  #...
  time = event_time("2012-10-26T08:45:42Z")
end

Could you try to use event_time test helper?

driver.emit({"name" => "Users"}, time)
driver.run
driver.run(default_tag: "groonga.command.table_create") do
driver.feed(time, {"name" => "Users"})
end
assert_equal("/d/table_create?name=Users",
@request_parser.request_url)
end
Expand All @@ -119,8 +120,9 @@ def test_one_message
@response_body = JSON.generate([[0, 0.0, 0.0], [1]])
driver = create_driver("log")
time = Time.parse("2012-10-26T08:45:42Z").to_i
driver.emit({"message" => "1st message"}, time)
driver.run
driver.run(default_tag: "log") do
driver.feed(time, {"message" => "1st message"})
end
assert_equal("/d/load?table=Logs",
@request_parser.request_url)
assert_equal([{"message" => "1st message"}],
Expand All @@ -131,9 +133,10 @@ def test_multiple_messages
@response_body = JSON.generate([[0, 0.0, 0.0], [2]])
driver = create_driver("log")
time = Time.parse("2012-10-26T08:45:42Z").to_i
driver.emit({"message" => "1st message"}, time)
driver.emit({"message" => "2nd message"}, time + 1)
driver.run
driver.run(default_tag: "log") do
driver.feed(time, {"message" => "1st message"})
driver.feed(time + 1, {"message" => "2nd message"})
end
assert_equal("/d/load?table=Logs",
@request_parser.request_url)
assert_equal([
Expand Down Expand Up @@ -231,8 +234,9 @@ class CommandTest < self
def test_basic_command
driver = create_driver("groonga.command.table_create")
time = Time.parse("2012-10-26T08:45:42Z").to_i
driver.emit({"name" => "Users"}, time)
driver.run
driver.run(default_tag: "groonga.command.table_create") do
driver.feed(time, {"name" => "Users"})
end
assert_equal([
[
"--input-fd", actual_input_fd,
Expand Down

0 comments on commit 4b581bd

Please sign in to comment.