Navigation Menu

Skip to content

Commit

Permalink
Add more tests for defaultSearchField
Browse files Browse the repository at this point in the history
  • Loading branch information
piroor committed Aug 14, 2012
1 parent 4dbe415 commit d1cbdd0
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 4 deletions.
2 changes: 1 addition & 1 deletion lib/database/index-field.js
Expand Up @@ -303,8 +303,8 @@ IndexField.prototype = {
this._searchEnabled);

if (this._defaultSearchField !== undefined) {
this.domain.defaultSearchField = this._defaultSearchField ? this : null ;
delete this._defaultSearchField;
this.domain.defaultSearchField = this;
}
},
deleteSync: function() {
Expand Down
12 changes: 9 additions & 3 deletions test/database-domain.test.js
Expand Up @@ -257,8 +257,8 @@ suite('database', function() {
});
});

test('setting default search field', function() {
assert.equal(domain.defaultSearchField, null, field);
test('setting default search field (instance)', function() {
assert.equal(domain.defaultSearchField, null);
var nameField = domain.getIndexField('name');
domain.defaultSearchField = nameField;
assert.equal(domain.defaultSearchField, nameField);
Expand All @@ -269,7 +269,7 @@ suite('database', function() {
});

test('setting default search field (text)', function() {
assert.equal(domain.defaultSearchField, null, field);
assert.equal(domain.defaultSearchField, null);
domain.defaultSearchField = 'name';
assert.equal(domain.defaultSearchField, domain.getIndexField('name'));

Expand All @@ -278,6 +278,12 @@ suite('database', function() {
anotherDomainInstance.getIndexField('name'));
});

test('setting default search field (unknown field)', function() {
assert.equal(domain.defaultSearchField, null);
domain.defaultSearchField = 'unknown';
assert.equal(domain.defaultSearchField, null);
});

test('removing default search field', function() {
var nameField = domain.getIndexField('name');
domain.defaultSearchField = nameField;
Expand Down
26 changes: 26 additions & 0 deletions test/database-index-field.test.js
Expand Up @@ -290,6 +290,32 @@ suite('database', function() {
field = new IndexField('product', domain); // reset instance from database
assert.equal('Search Facet Result', field.options);
});

test('setting default search field', function() {
var field = new IndexField('product', domain).setType('literal');
field.createSync();

field.defaultSearchField = true;
field.saveOptionsSync();
assert.equal(domain.defaultSearchField,
domain.getIndexField('product'));

field.defaultSearchField = true;
field.saveOptionsSync();
assert.equal(domain.defaultSearchField, null);
});

test('auto-remove default search field', function() {
var field = new IndexField('product', domain).setType('literal');
field.createSync();
field.defaultSearchField = true;
field.saveOptionsSync();
assert.equal(domain.defaultSearchField,
domain.getIndexField('product'));

field.deleteSync();
assert.equal(domain.defaultSearchField, null);
});
});

suite('database modifications', function() {
Expand Down

0 comments on commit d1cbdd0

Please sign in to comment.