Navigation Menu

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: groonga/groonga
base: 31cd5fceee3b
Choose a base ref
...
head repository: groonga/groonga
compare: d1845f79a2ea
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jun 11, 2013

  1. clang: suppress a warning 

    Initialize grn_id explicitly.

    db.c:2430:7: warning: variable 'id' is used uninitialized whenever 'if'
          condition is false [-Wsometimes-uninitialized]
          WITH_NORMALIZE(hash, key, key_size, {
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    db.c:46:9: note: expanded from macro 'WITH_NORMALIZE'
        if ((nstr = grn_string_open(ctx, key, key_size,\
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    db.c:2433:11: note: uninitialized use occurs here
          if (id) { grn_table_add(ctx, res, &id, sizeof(grn_id), NULL); }
              ^~
    db.c:2430:7: note: remove the 'if' if its condition is always true
          WITH_NORMALIZE(hash, key, key_size, {
          ^
    db.c:46:5: note: expanded from macro 'WITH_NORMALIZE'
        if ((nstr = grn_string_open(ctx, key, key_size,\
        ^
    db.c:2429:16: note: initialize the variable 'id' to silence this warning
          grn_id id;
                   ^
                    = 0
    @kou
    kou committed Jun 11, 2013
    Copy the full SHA
    d1845f7 View commit details
    Browse the repository at this point in the history