Navigation Menu

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: groonga/groonga
base: 4ab718beb858
Choose a base ref
...
head repository: groonga/groonga
compare: 46354384a3e4
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jun 11, 2013

  1. clang: suppress warnings 

    Use uint32_t for object type. It should be uint8_t but GRN_B_DEC()
requires uint32_t for result space. So I use uint32_t instead of
uint8_t.

    lib/expr.c:440:18: warning: comparison of
          constant 32 with expression of type 'grn_expr_pack_type' is always false
          [-Wtautological-constant-out-of-range-compare]
        if (GRN_TYPE <= type && type <= GRN_COLUMN_INDEX) { /* error */ }
            ~~~~~~~~ ^  ~~~~
    lib/expr.c:440:34: warning: comparison of
          constant 72 with expression of type 'grn_expr_pack_type' is always true
          [-Wtautological-constant-out-of-range-compare]
        if (GRN_TYPE <= type && type <= GRN_COLUMN_INDEX) { /* error */ }
                                ~~~~ ^  ~~~~~~~~~~~~~~~~
    lib/expr.c:467:20: warning: comparison of
          constant 32 with expression of type 'grn_expr_pack_type' is always false
          [-Wtautological-constant-out-of-range-compare]
          if (GRN_TYPE <= type && type <= GRN_COLUMN_INDEX) {
              ~~~~~~~~ ^  ~~~~
    lib/expr.c:467:36: warning: comparison of
          constant 72 with expression of type 'grn_expr_pack_type' is always true
          [-Wtautological-constant-out-of-range-compare]
          if (GRN_TYPE <= type && type <= GRN_COLUMN_INDEX) {
                                  ~~~~ ^  ~~~~~~~~~~~~~~~~
    @kou
    kou committed Jun 11, 2013
    Copy the full SHA
    4635438 View commit details
    Browse the repository at this point in the history