Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fix Bug 735888 always build language tree after migration

  • Loading branch information...
commit 7eb23be8459ec9b77dc41a2ebac90a4ccc5ca803 1 parent 2cf65bd
luke crouch authored
Showing with 2 additions and 5 deletions.
  1. +2 −5 apps/dekicompat/management/commands/migrate_to_kuma_wiki.py
7 apps/dekicompat/management/commands/migrate_to_kuma_wiki.py
View
@@ -154,9 +154,6 @@ class Command(BaseCommand):
make_option('--syntax-metrics', action="store_true",
dest="syntax_metrics", default=False,
help="Measure syntax highlighter usage, skip migration"),
- make_option('--language-rels', action="store_true",
- dest="language_rels", default=False,
- help="Build page languages tree, skip migration"),
make_option('--limit', dest="limit", type="int", default=99999,
help="Stop after a migrating a number of documents"),
@@ -200,10 +197,10 @@ def handle(self, *args, **options):
self.handle_template_metrics(rows)
elif options['syntax_metrics']:
self.handle_syntax_metrics(rows)
- elif options['language_rels']:
- self.make_languages_relationships(rows)
else:
self.handle_migration(rows)
+ rows = self.gather_pages()

Last nit - now that this happens all the time, there should also be an option to skip it. I tried this, and it took me a few seconds to realize why 11 documents were being migrated:

./manage.py migrate_to_kuma_wiki --slug=en/CSS

But, I don't think that's enough of a nit not to merge and get this closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ self.make_languages_relationships(rows)
def init(self, options):
"""Set up connections and options"""
Les Orchard

Last nit - now that this happens all the time, there should also be an option to skip it. I tried this, and it took me a few seconds to realize why 11 documents were being migrated:

./manage.py migrate_to_kuma_wiki --slug=en/CSS

But, I don't think that's enough of a nit not to merge and get this closed

Please sign in to comment.
Something went wrong with that request. Please try again.