Add error_response and interval_on_error option #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To wait until sending NACK
taigou
approved these changes
May 23, 2018
nagachika
approved these changes
May 23, 2018
minimum2scp
approved these changes
May 23, 2018
y-hattori
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
nack_on_errortoerror_responseand modify its type from bool to enum.error_responsehas optionsack,nackornone.If
error_responseisnone, blocks-gcs-proxy doesn't return any response to subscription on error.And rename
error_intervaltointerval_on_error.It's used to wait with any
error_responseSee https://github.com/groovenauts/blocks-gcs-proxy/blob/features/nack_interval/README.md for more detail.