Upgrade to Bootstrap 2.0.2 #25

Merged
merged 1 commit into from Mar 18, 2012

Conversation

Projects
None yet
3 participants
@LordOfTheRams
Contributor

LordOfTheRams commented Mar 15, 2012

Hi!

I had some issues with the paginator, so had to upgrade bootstrap to 2.0.2, because it better supports disabled links (via instead of ). I also added some styles to the fixtaglib stylesheet and changed the paginator taglib to use for disabled links. Hope you like it.

Regards
Werner (LordOfTheRams)

@groovydev groovydev closed this Mar 18, 2012

@groovydev groovydev reopened this Mar 18, 2012

groovydev pushed a commit that referenced this pull request Mar 18, 2012

Karol Balejko
Merge pull request #25 from LordOfTheRams/master
Upgrade to Bootstrap 2.0.2

@groovydev groovydev merged commit ad68d5e into groovydev:master Mar 18, 2012

@groovydev

This comment has been minimized.

Show comment Hide comment
@groovydev

groovydev Mar 18, 2012

Owner

Thanks for your update.

There is error compiling less file:

| Error 2012-03-18 20:08:29,659 [pool-7-thread-1] ERROR resourceMappers.LesscssResourceMapper - error compiling less file: /home/workspace/.grails/2.0.1/projects/groovydev-jointly/tomcat/work/Tomcat/localhost/groovydev-jointly/grails-resources/plugins/twitter-bootstrap-2.0.1.23/work/bootstrap.less
| Error com.asual.lesscss.LessException: com.asual.lesscss.LessException: Parse Error: Syntax Error on line 396 (line 396, column 8) near
.reset-filter() {
filter: progid:DXImageTransform.Microsoft.gradient(enabled = false);
}
| Error at com.asual.lesscss.LessEngine.parseLessException(LessEngine.java:188)

It looks that there is syntax error in mixins.less at line 396. I guess it is the same issue like this:
dotless/dotless#155

Owner

groovydev commented Mar 18, 2012

Thanks for your update.

There is error compiling less file:

| Error 2012-03-18 20:08:29,659 [pool-7-thread-1] ERROR resourceMappers.LesscssResourceMapper - error compiling less file: /home/workspace/.grails/2.0.1/projects/groovydev-jointly/tomcat/work/Tomcat/localhost/groovydev-jointly/grails-resources/plugins/twitter-bootstrap-2.0.1.23/work/bootstrap.less
| Error com.asual.lesscss.LessException: com.asual.lesscss.LessException: Parse Error: Syntax Error on line 396 (line 396, column 8) near
.reset-filter() {
filter: progid:DXImageTransform.Microsoft.gradient(enabled = false);
}
| Error at com.asual.lesscss.LessEngine.parseLessException(LessEngine.java:188)

It looks that there is syntax error in mixins.less at line 396. I guess it is the same issue like this:
dotless/dotless#155

@robfletcher

This comment has been minimized.

Show comment Hide comment
@robfletcher

robfletcher Apr 2, 2012

I'm not sure it's a syntax error, it might well be that the LESS compiler used by the lesscss-resources plugin doesn't cope with MS filter directives unless they are escaped. The previous version of mixins.less had this:

filter: e(%("progid:DXImageTransform.Microsoft.gradient(enabled = false)"));

whereas the new one has:

filter: progid:DXImageTransform.Microsoft.gradient(enabled = false);

Commenting out that line I then get subsequent errors from any rule that uses LESS's when keyword which is also only used in the newest version of mixins.less.

I'm not sure it's a syntax error, it might well be that the LESS compiler used by the lesscss-resources plugin doesn't cope with MS filter directives unless they are escaped. The previous version of mixins.less had this:

filter: e(%("progid:DXImageTransform.Microsoft.gradient(enabled = false)"));

whereas the new one has:

filter: progid:DXImageTransform.Microsoft.gradient(enabled = false);

Commenting out that line I then get subsequent errors from any rule that uses LESS's when keyword which is also only used in the newest version of mixins.less.

@groovydev

This comment has been minimized.

Show comment Hide comment
@groovydev

groovydev Apr 5, 2012

Owner

Yes, you're right. It is problem with LESS compiler used by the lesscss-resources plugin. I've write new less-resources plugin capable to compile less v1.3.0 and bootstrap v2.0.2 without error (http://grails.org/plugin/less-resources). New updated twitter-bootstrap plugin v2.0.2.24 can use it.

Owner

groovydev commented Apr 5, 2012

Yes, you're right. It is problem with LESS compiler used by the lesscss-resources plugin. I've write new less-resources plugin capable to compile less v1.3.0 and bootstrap v2.0.2 without error (http://grails.org/plugin/less-resources). New updated twitter-bootstrap plugin v2.0.2.24 can use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment