Performance Improvements to preprocess + small changes in main - #2
Merged
Merged
Conversation
…pace; improves initial load time for secat
… normalization.normalize() function; progress bar for uniprot entry appending
dgorhe
marked this pull request as ready for review
October 4, 2022 20:25
grosenberger
approved these changes
Oct 5, 2022
grosenberger
left a comment
Owner
There was a problem hiding this comment.
Great work, thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, I'm working in Marko Jovanovic's lab at Columbia University and I wanted to pull in some changes to SECAT. We use SECAT a lot but it takes a lot of time to run so I made some performance improvements that should help the average user. Some changes are more oriented toward general usability. The changes include:
from pandas import read_csvvsimport pandas as pd)read_csvcalls inpreprocess.pywherever a separator is specified to improve parsing performanceuniprotclass withinpreprocess.pydf['run_id']column is all strings before using thepandas.DataFrame.applymethod withinquantification.read_long()andquantification_read_matrix()inpreprocess.pynormalization.slide_normalize()to use all available cores to normalize windows in parallelLet me know if you have any feedback for these changes. Thanks!