New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuntimeLogger: Include TEST_ENV_NUMBER #572

Closed
der-flo opened this Issue Jun 28, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@der-flo

der-flo commented Jun 28, 2017

Testing is hard so from time to time we have flickering specs based on the execution order.
Unfortunately the RuntimeLogger doesn't output the process number (ENV['TEST_ENV_NUMBER']) so it's hard for us to spot the specs running together in one process.

Changing the RuntimeLogger#start_dump seems quite easy:

@output.puts "#{relative_path}:#{time > 0 ? time : 0}:#{ENV['TEST_ENV_NUMBER']}"

Would a pull request like this one get accepted? Other opinions?

@grosser

This comment has been minimized.

Show comment
Hide comment
@grosser

grosser Jun 29, 2017

Owner

hmmm feels like something that's not the job of the runtime logger ...
maybe add a new grouping-logger ?
how about running with --verbose, that already shows what tests are in the same group and gives nice copy-pasteable output to re-run things

Owner

grosser commented Jun 29, 2017

hmmm feels like something that's not the job of the runtime logger ...
maybe add a new grouping-logger ?
how about running with --verbose, that already shows what tests are in the same group and gives nice copy-pasteable output to re-run things

@der-flo

This comment has been minimized.

Show comment
Hide comment
@der-flo

der-flo Jun 29, 2017

Both are good points. I didn't know the --verbose option. I'll think about it.

You're willing to merge a pull request containing an additional, but only slightly modified version of the RuntimeLogger?

der-flo commented Jun 29, 2017

Both are good points. I didn't know the --verbose option. I'll think about it.

You're willing to merge a pull request containing an additional, but only slightly modified version of the RuntimeLogger?

@grosser

This comment has been minimized.

Show comment
Hide comment
@grosser

grosser Jun 29, 2017

Owner

prefer not to have an almost identical logger ... maybe have a verbose logger that only logs when the test run fails so it can be added to regular runs without spamming

Owner

grosser commented Jun 29, 2017

prefer not to have an almost identical logger ... maybe have a verbose logger that only logs when the test run fails so it can be added to regular runs without spamming

@der-flo

This comment has been minimized.

Show comment
Hide comment
@der-flo

der-flo Jul 4, 2017

Your suggestions went a bit to far for me. In my project I created a RuntimeWithProcessNumberLogger with inherits from RuntimeLogger.
That solves the issue for me by now. You may close this issue, thanks.

der-flo commented Jul 4, 2017

Your suggestions went a bit to far for me. In my project I created a RuntimeWithProcessNumberLogger with inherits from RuntimeLogger.
That solves the issue for me by now. You may close this issue, thanks.

@grosser grosser closed this Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment