Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ruby 2.4 support and test against latest ruby & rails #808

Merged
merged 13 commits into from Mar 25, 2021

Conversation

deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Mar 25, 2021

This gets the library in sync with Rails support range, which makes things easier.

Checklist

  • Feature branch is up-to-date with master (if not - rebase it).
  • Added tests.
  • Added an entry to the Changelog if the new
    code introduces user-observable changes.
  • Update Readme.md when cli options are changed

Generated with

```
rails new spec/fixtures/rails61 --skip-listen --skip-spring --skip-bootsnap --skip-sprockets --skip-gemfile --skip-webpack-install
rails _6.0.3_ new spec/fixtures/rails60 --skip-listen --skip-spring --skip-bootsnap --skip-sprockets --skip-gemfile --skip-webpack-install
rm -rf spec/fixtures/rails61/.git spec/fixtures/rails60/.git
git add spec/fixtures/rails6*
```
Through `bundle lock --add-platform x64-mingw32`.

Favor that over `force_ruby_platform`.
@deivid-rodriguez
Copy link
Contributor Author

@deivid-rodriguez deivid-rodriguez commented Mar 25, 2021

Ok, this PR got a bit out of hand, and it does a few different things. Happy to split it to separate PRs if needed. What it does is:

  • Get CI green.
  • Migrate dummy test apps from Rails 5.1-.5.2 to Rails 6.0-6.1.
  • Drop support for ruby 2.4.

@grosser
Copy link
Owner

@grosser grosser commented Mar 25, 2021

wow ... somehow even windows is happy 💖

@grosser grosser merged commit b83e903 into grosser:master Mar 25, 2021
13 checks passed
@deivid-rodriguez
Copy link
Contributor Author

@deivid-rodriguez deivid-rodriguez commented Mar 25, 2021

Yeah, I cheated a bit, but all other similar specs were already skipped on Windows.

@deivid-rodriguez deivid-rodriguez deleted the dev_updates branch Mar 25, 2021
@deivid-rodriguez
Copy link
Contributor Author

@deivid-rodriguez deivid-rodriguez commented Mar 25, 2021

Thanks!

@grosser
Copy link
Owner

@grosser grosser commented Mar 25, 2021

a few skipped tests is better than letting new red ones in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants