redundant comparison

grosser · May 30, 2010 · 870686f · 870686f
1 parent 8f7404d
commit 870686f
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/lib/rack/bug/params_signature.rb b/lib/rack/bug/params_signature.rb
@@ -36,9 +36,7 @@ def secret_key_blank?
       def validate!
         if secret_key_blank?
           raise SecurityError.new("Missing secret key")
-        end
-
-        if secret_key_blank? || request.params["hash"] != signature(request.params)
+        elsif request.params["hash"] != signature(request.params)
           raise SecurityError.new("Invalid query hash.")
         end
       end