Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ontario (Canada) region. #157

Merged
merged 1 commit into from Feb 18, 2016

Conversation

@chimo
Copy link
Contributor

commented Feb 15, 2016

Hi!
As discussed, here's the PR for Ontario, Canada.

Please let me know if anything needs to be changed

@grote

This comment has been minimized.

Copy link
Owner

commented Feb 15, 2016

Awesome, looks really good! :) Do you also want to add a logo, maybe the flag of Ontario or if there's one public transport company, use theirs?

@chimo

This comment has been minimized.

Copy link
Contributor Author

commented Feb 16, 2016

Looks like "the official 'symbols' of the Government of Ontario" can't be used without the government's written authorization (I'm guessing this includes the flag, but I could be wrong...), and there are more than one public transport providers in that region.

Let me know if you have any ideas on how to proceed!

@grote

This comment has been minimized.

Copy link
Owner

commented Feb 16, 2016

Wikipedia says that the flag and the coat of arms are in the public domain. But maybe it could just be a red Maple Leaf on white background with ON written in the bottom right corner? So other states of Canada could be added later using the same logo principle?

@grote

This comment has been minimized.

Copy link
Owner

commented Feb 17, 2016

How about this?
network_ontario_logo

@chimo

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2016

Sorry for the delay; didn't get the chance to look at this yesterday.

Good idea, looks really good!
Should I include it in this PR or you prefer adding it yourself after? (I wouldn't want to take credit for your work)

@grote

This comment has been minimized.

Copy link
Owner

commented Feb 17, 2016

Either way, I don't care ;)
Thanks a gain for your contribution! If you are interested in adding other providers, I'd be very happy about that! :)

@chimo chimo force-pushed the chimo:ontario branch from 2ed7445 to d8f4ccb Feb 18, 2016
@chimo

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2016

Logo added!

@grote grote merged commit d8f4ccb into grote:master Feb 18, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chimo chimo deleted the chimo:ontario branch Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.