Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on SQLITE_ENABLE_SNAPSHOT #847

Merged
merged 2 commits into from Oct 6, 2020
Merged

Remove dependency on SQLITE_ENABLE_SNAPSHOT #847

merged 2 commits into from Oct 6, 2020

Conversation

groue
Copy link
Owner

@groue groue commented Oct 6, 2020

This pull request addresses #845 and #846

@groue groue added the bug label Oct 6, 2020
@groue groue merged commit f8a0e8e into development Oct 6, 2020
@groue groue deleted the dev/remove-snapshots branch October 6, 2020 11:32
@harryworld
Copy link

Thanks for the quick work.
So from now on, GRDB has SQLITE_ENABLE_SNAPSHOT turned off by default?

@groue
Copy link
Owner Author

groue commented Oct 6, 2020

Yes @harryworld. SQLITE_ENABLE_SNAPSHOT is still used for ValueObservation optimization, but only when this flag has explicitly been made available by a custom SQLite build.

@groue
Copy link
Owner Author

groue commented Dec 3, 2021

I asked Apple to expose it publicly in FB9793771 (Expose SQLite APIs enabled by the SQLITE_ENABLE_SNAPSHOT compilation option)

@groue groue added the needs revisiting This issue was closed but it has unfinished business label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug needs revisiting This issue was closed but it has unfinished business
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@groue @harryworld