Add Pipedrive Organizations Export #2556

aelafifi · 2021-11-18T18:21:58Z

Change description

Added Pipedrive export organizations destination (with needed tests for it).
Refactored the file structure and made plugin functionality more reusable.

Checklists

Development

Application changes have been tested appropriately

Impact

Code follows company security practices and guidelines
Security impact of change has been considered
Performance impact of change has been considered
Possible migration needs considered (model migrations, config migrations, etc.)

Please explain any security, performance, migration, or other impacts if relevant:

Code review

Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached where applicable.
Relevant tags have been added to the PR (bug, enhancement, internal, etc.)

- Generalize common API calls. - Add API calls for organizations.

Examples of code changes depending on that: - `client.deletePerson()` -> `client.persons.delete()` - `client.getAllPersonFields()` -> `client.persons.fields.getAll()` - `client.getAllPersonFilters()` -> `client.persons.filters.getAll()`

…export' into feature/pipedrive-organizations-export

evantahler

Good start!

The next step would be to add tests for exporting Orginizations. We should re-orginize the test suite to have an export record test for both Profiles and Organizations. We use nock to actually record the the HTTP requests locally so we can ensure that the API is being used the way we expect.

Also a suggestion for the linter - if you are using VSCode, install the prettier plugin and your files will be auto-formatter on save.

evantahler · 2021-11-18T18:50:34Z

plugins/@grouparoo/pipedrive/src/lib/client.ts

+type Entity = 'persons' | 'organizations';
+type EntityField = 'personFields' | 'organizationFields';
+type FilterType = 'people' | 'org';
+
+const EntityFieldMapping: Record<Entity,  EntityField> = {
+  persons: "personFields",
+  organizations: "organizationFields",
+};
+
+const FilterTypeMapping: Record<Entity, FilterType> = {
+  persons: "people",
+  organizations: "org",
+};


👍 really good typing!

bleonard

Looking like a good start of re-use.

plugins/@grouparoo/pipedrive/src/lib/client.ts

bleonard

Looking good!

plugins/@grouparoo/pipedrive/src/initializers/plugin.ts

bleonard · 2021-11-23T21:12:22Z

plugins/@grouparoo/pipedrive/src/lib/export/organizations/destinationMappingOptions.ts

+    daterange: "date",
+
+    // TODO
+    time: null, // time in the format of "00:00:00"


@pauloouriques is mapping many of these to string. I think we can do that here too for time

By looking to this function

function formatVar(value) { if (value === undefined) { return null; } if (value instanceof Date) { return value.toISOString(); } return value; }

Mapping dates are applicable because there is a type Date, in our case here, how to detect time values??

We don;t have the type of "time" but making this a string will allow the user to come up with their own string property in the right format and be able to set the remote field.

plugins/@grouparoo/pipedrive/src/lib/export/organizations/destinationMappingOptions.ts

plugins/@grouparoo/pipedrive/src/lib/export/persons/destinationMappingOptions.ts

bleonard

Looking good. interested in any refactorings that we should do.

plugins/@grouparoo/pipedrive/src/initializers/plugin.ts

bleonard · 2021-11-30T18:59:36Z

plugins/@grouparoo/pipedrive/src/lib/client.ts

+    this.request.interceptors.response.use(
+      (response) => response,
+      (error) => {
+        if (error.code === "ECONNRESET") {


Any idea why this was happening? is it different than rate limiting?

This happens when you have local network issues and trying to send many requests in a few amount of time!

plugins/@grouparoo/pipedrive/src/lib/export-organizations/destinationMappingOptions.ts

bleonard

maybe more complex but it's DRY'd up. Few notes on caching in particular. Some likely issues if those keys are shared across types.

plugins/@grouparoo/pipedrive/src/lib/common/listMethods.ts

plugins/@grouparoo/pipedrive/src/lib/common/destinationMappingOptions.ts

plugins/@grouparoo/pipedrive/src/lib/common/configMapping.ts

plugins/@grouparoo/pipedrive/src/lib/common/destinationMappingOptions.ts

plugins/@grouparoo/pipedrive/src/lib/common/listMethods.ts

…export' into feature/pipedrive-organizations-export

addressed

Ahmed El-Afifi added 2 commits November 18, 2021 18:43

Add organization API calls for Pipedrive client

06dbe7e

- Generalize common API calls. - Add API calls for organizations.

Split & group similar function in the same place

9ccc98a

Examples of code changes depending on that: - `client.deletePerson()` -> `client.persons.delete()` - `client.getAllPersonFields()` -> `client.persons.fields.getAll()` - `client.getAllPersonFilters()` -> `client.persons.filters.getAll()`

aelafifi requested review from bleonard and evantahler November 18, 2021 18:21

grouparoo-bot and others added 3 commits November 18, 2021 18:22

Updating things automatically

ef5e682

Change client API calls regarding previous updates

0e5f837

Merge remote-tracking branch 'origin/feature/pipedrive-organizations-…

b3acd13

…export' into feature/pipedrive-organizations-export

evantahler previously requested changes Nov 18, 2021

View reviewed changes

bleonard reviewed Nov 18, 2021

View reviewed changes

krishnaglick reviewed Nov 18, 2021

View reviewed changes

plugins/@grouparoo/pipedrive/src/lib/client.ts Outdated Show resolved Hide resolved

plugins/@grouparoo/pipedrive/src/lib/client.ts Outdated Show resolved Hide resolved

Ahmed El-Afifi added 7 commits November 18, 2021 21:08

Update tests regarding Pipedrive client changes

47226f0

Prettify client.ts

c571701

Merge branch 'main' into feature/pipedrive-organizations-export

2d2f582

Restructure exports and add organizations export

c0b1d50

Fix initializers issue

32404a8

Add tests for organizations

5ceb484

Merge branch 'main' into feature/pipedrive-organizations-export

5ef81fe

bleonard reviewed Nov 23, 2021

View reviewed changes

Ahmed El-Afifi added 7 commits November 30, 2021 18:14

Add response interceptor to handle connection errors

d266d75

Fix directory structure

85ec95c

Fix comment

b09759b

Fix comment

8053328

Fixes regarding PR change requests

3f5222a

Fix imports and unused vars

c36c711

Remove unneeded log

196dfc0

bleonard reviewed Nov 30, 2021

View reviewed changes

Ahmed El-Afifi added 2 commits December 1, 2021 00:38

Refactoring common functionality

139313b

Remove un-intended change

7ac0775

aelafifi added the plugin label Nov 30, 2021

aelafifi marked this pull request as ready for review November 30, 2021 22:58

Ahmed El-Afifi added 2 commits December 1, 2021 01:13

Fix a typo

3c0f323

Add support for time fields

d68a3df

bleonard suggested changes Dec 1, 2021

View reviewed changes

Ahmed El-Afifi and others added 5 commits December 2, 2021 19:46

Unneeded exports removed, and cache keys enhanced

5e96205

Updating things automatically

4f34288

Merge branch 'main' into feature/pipedrive-organizations-export

0776ea3

Merge remote-tracking branch 'origin/feature/pipedrive-organizations-…

5d1bed8

…export' into feature/pipedrive-organizations-export

Fix for linter

99ff674

bleonard self-requested a review December 2, 2021 19:17

bleonard approved these changes Dec 2, 2021

View reviewed changes

prettier . --write

ecfc243

bleonard added the enhancement New feature or request label Dec 2, 2021

bleonard merged commit ce20980 into main Dec 3, 2021

bleonard deleted the feature/pipedrive-organizations-export branch December 3, 2021 17:19

bleonard mentioned this pull request Jan 5, 2022

Pipedrive Organizations #2533

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Pipedrive Organizations Export #2556

Add Pipedrive Organizations Export #2556

aelafifi commented Nov 18, 2021 •

edited

Loading

evantahler left a comment

evantahler Nov 18, 2021

bleonard left a comment

bleonard left a comment

bleonard Nov 23, 2021

aelafifi Nov 30, 2021

bleonard Dec 2, 2021

bleonard left a comment

bleonard Nov 30, 2021

aelafifi Nov 30, 2021

bleonard left a comment

Add Pipedrive Organizations Export #2556

Add Pipedrive Organizations Export #2556

Conversation

aelafifi commented Nov 18, 2021 • edited Loading

Change description

Checklists

Development

Impact

Code review

evantahler left a comment

Choose a reason for hiding this comment

evantahler Nov 18, 2021

Choose a reason for hiding this comment

bleonard left a comment

Choose a reason for hiding this comment

bleonard left a comment

Choose a reason for hiding this comment

bleonard Nov 23, 2021

Choose a reason for hiding this comment

aelafifi Nov 30, 2021

Choose a reason for hiding this comment

bleonard Dec 2, 2021

Choose a reason for hiding this comment

bleonard left a comment

Choose a reason for hiding this comment

bleonard Nov 30, 2021

Choose a reason for hiding this comment

aelafifi Nov 30, 2021

Choose a reason for hiding this comment

bleonard left a comment

Choose a reason for hiding this comment

aelafifi commented Nov 18, 2021 •

edited

Loading