Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Add location as App option for BigQuery #2596

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Conversation

teallarson
Copy link
Contributor

@teallarson teallarson commented Dec 1, 2021

Change description

Previously, because BigQuery defaults to US, we could only support US datasets. This PR adds an optional appOption to BigQuery plugin for the region or multi-region code of a BigQuery dataset, passes that as part of the connection. This is only required for users with a dataset outside the United States.

Screen Shot 2021-12-01 at 10 42 35 AM

Checklists

Development

  • Application changes have been tested appropriately

Impact

  • Code follows company security practices and guidelines
  • Security impact of change has been considered
  • Performance impact of change has been considered
  • Possible migration needs considered (model migrations, config migrations, etc.)

Please explain any security, performance, migration, or other impacts if relevant:

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached where applicable.
  • Relevant tags have been added to the PR (bug, enhancement, internal, etc.)

@teallarson teallarson added the enhancement New feature or request label Dec 1, 2021
@teallarson
Copy link
Contributor Author

teallarson commented Dec 1, 2021

Wasn't sure on testing here. It looks like App Options aren't widely tested. In the UI, if someone puts in a bogus region code, the worst that happens is it returns "0 tables found", same as if they enter a bogus dataset name.

@teallarson teallarson marked this pull request as ready for review December 1, 2021 15:46
@evantahler evantahler changed the title add location as app option on bigquery Add location as App option for BigQuery Dec 1, 2021
@teallarson
Copy link
Contributor Author

We decided to not move forward with making the option required with a default as it caused unwanted side effects and BigQuery uses US as a default already. I reset the commit where we tried it out.

@teallarson teallarson merged commit 73cde21 into main Dec 2, 2021
@teallarson teallarson deleted the bigquery-location-option branch December 2, 2021 00:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants