This repository was archived by the owner on Apr 12, 2022. It is now read-only.
Salesforce destination split out#2631
Merged
Merged
Conversation
735e7d1 to
ca5982b
Compare
bleonard
reviewed
Dec 7, 2021
Member
bleonard
left a comment
There was a problem hiding this comment.
Looking good. I think there's some tactics to shred more code and make it more declarative as noted.
| exportArrayProperties, | ||
| }, | ||
| }, | ||
| accountsDestinationConnection, |
| @@ -0,0 +1,60 @@ | |||
| import { | |||
Member
There was a problem hiding this comment.
This method is almost exactly the same as the -contacts (and -objects?) one. That's true for many of these files.
I feel like there is an oppurtunity have a meta concept where you pass what's important (model defaults, known special fields to a single method (or maybe one each) and get back all the methods that implement the destination. TSo the desitnation-specific code would all be in connection.
See how app-templates buildConnection is used here:
https://github.com/grouparoo/grouparoo/blob/main/plugins/%40grouparoo/postgres/src/lib/table-import/connection.ts
export function getConnection() {
return buildConnection({
apps: ["postgres"],
name: "postgres-import-table",
displayName: "Postgres Table Import",
description: "Import or update Records from a Postgres database table.",
tableOptionDescription: "The table to scan",
getSampleRows,
getColumns,
getTables,
getChangedRows,
getPropertyValue,
getPropertyValues,
getChangedRowCount,
});
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
This PR contains the most common usages of the Salesforce destination split out into separated destinations.
Checklists
Development
Impact
Please explain any security, performance, migration, or other impacts if relevant:
Code review