New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Alerts in API.md #125

Merged
merged 2 commits into from Jan 21, 2015

Conversation

Projects
None yet
2 participants
@azu
Contributor

azu commented Jan 21, 2015

I just updated the API.md to have the up-to-date API.

  • browser.alert.getText() - > browser.getAlertText()
  • browser.alert.accept() - > browser.acceptAlert()
  • browser.alert.dismiss() -> browser.dismissAlert()
  • browser.typeAlert('') -> browser.alert.type('')

ref. https://github.com/groupon-testium/testium/blob/fb7940dcb1a16213a77d5d97a824a8820f7c4bea/src/browser/alert.coffee#L35-L48

azu added some commits Jan 21, 2015

Update Alerts in API.md
updated the API.md to have the up-to-date API.

- browser.alert.getText() - > browser.getAlertText()
- browser.alert.accept() - > browser.acceptAlert()
- browser.alert.dismiss() -> browser.dismissAlert()
- browser.typeAlert('') -> browser.alert.type('')
@EndangeredMassa

This comment has been minimized.

Show comment
Hide comment
@EndangeredMassa

EndangeredMassa Jan 21, 2015

Collaborator

Thanks!

Collaborator

EndangeredMassa commented Jan 21, 2015

Thanks!

EndangeredMassa added a commit that referenced this pull request Jan 21, 2015

@EndangeredMassa EndangeredMassa merged commit 1ac5413 into groupon:master Jan 21, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@azu azu deleted the azu:patch-1 branch Jan 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment