Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small windows format parse bug #10

Closed
wmnwmn opened this issue Aug 31, 2016 · 1 comment

Comments

@wmnwmn
Copy link

commented Aug 31, 2016

Query sequence headers of this form are not parsed right:
>Acession\r\n
i.e., they have the windows-style newlines, and no other whitespace.

I will be submitting a fix on this issue.

groupschoof pushed a commit that referenced this issue Sep 2, 2016
Fixed issue #10
Proposed fix is not as flexible as the one implemented here.
Problem was caused by non *nix like line breaks like '\r'.
Now using regex (\r|\n)+ to split String into lines.
@groupschoof

This comment has been minimized.

Copy link
Owner

commented Sep 2, 2016

Dear wmnwmn,

thank you very much for bringing this up and proposing a fix. Based on your suggestion I implemented a similar, slightly more flexible solution. It is now included in tag v3.3.2 (latest master).

Cheers!

@groupschoof groupschoof closed this Sep 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.