Secure file uploads when NODE_ENV=dev #487
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If a user fails to set NODE_ENV=production, our built-in security checks are disabled and it's possible to misconfigure GrowthBook and leave the file upload API endpoint open to attack.
To be affected, ALL of the following must be true
To solve these security vulnerabilities, this PR makes 3 changes:
localhost(in case someone forgets to update NODE_ENV)What should you do if you are potentially affected:
NODE_ENVis set to "production"JWT_SECRETenvironment variable to a long random string