New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a single swagger definition on demand #658

Merged
merged 2 commits into from May 23, 2018

Conversation

Projects
None yet
6 participants
@achew22
Collaborator

achew22 commented May 23, 2018

Combines the efforts of @cy-zheng in #643 with the efforts of @zxy198717 in #591.

Fixes: #643, #591, #99

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot May 23, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot commented May 23, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no label May 23, 2018

@achew22

This comment has been minimized.

Show comment
Hide comment
@achew22

achew22 May 23, 2018

Collaborator

I manually edited both changes to leave authorship with their respective author, rebased and uploaded. This can now fix a long standing issue. Thanks so much everyone!

Collaborator

achew22 commented May 23, 2018

I manually edited both changes to leave authorship with their respective author, rebased and uploaded. This can now fix a long standing issue. Thanks so much everyone!

@hexfusion

This comment has been minimized.

Show comment
Hide comment
@hexfusion

hexfusion May 23, 2018

Contributor

@achew22 any idea when this might be released? Would it make 1.4.x?

Contributor

hexfusion commented May 23, 2018

@achew22 any idea when this might be released? Would it make 1.4.x?

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io May 23, 2018

Codecov Report

Merging #658 into master will decrease coverage by 1.15%.
The diff coverage is 6.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   58.94%   57.78%   -1.16%     
==========================================
  Files          30       30              
  Lines        2857     2914      +57     
==========================================
  Hits         1684     1684              
- Misses       1010     1066      +56     
- Partials      163      164       +1
Impacted Files Coverage Δ
protoc-gen-swagger/genswagger/generator.go 0% <0%> (ø) ⬆️
protoc-gen-grpc-gateway/descriptor/registry.go 71.03% <0%> (-3.25%) ⬇️
protoc-gen-swagger/genswagger/template.go 42.1% <100%> (-0.25%) ⬇️
protoc-gen-swagger/main.go 27.38% <42.85%> (+1.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ba578...e7b79eb. Read the comment docs.

codecov-io commented May 23, 2018

Codecov Report

Merging #658 into master will decrease coverage by 1.15%.
The diff coverage is 6.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   58.94%   57.78%   -1.16%     
==========================================
  Files          30       30              
  Lines        2857     2914      +57     
==========================================
  Hits         1684     1684              
- Misses       1010     1066      +56     
- Partials      163      164       +1
Impacted Files Coverage Δ
protoc-gen-swagger/genswagger/generator.go 0% <0%> (ø) ⬆️
protoc-gen-grpc-gateway/descriptor/registry.go 71.03% <0%> (-3.25%) ⬇️
protoc-gen-swagger/genswagger/template.go 42.1% <100%> (-0.25%) ⬇️
protoc-gen-swagger/main.go 27.38% <42.85%> (+1.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ba578...e7b79eb. Read the comment docs.

@achew22 achew22 merged commit cb416f8 into grpc-ecosystem:master May 23, 2018

1 of 2 checks passed

cla/google CLAs are signed, but unable to verify author consent
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@achew22 achew22 deleted the achew22:one_swagger_output branch May 23, 2018

@achew22

This comment has been minimized.

Show comment
Hide comment
@achew22
Collaborator

achew22 commented May 23, 2018

@hexfusion

This comment has been minimized.

Show comment
Hide comment
@hexfusion

hexfusion May 23, 2018

Contributor

Perfect thanks a lot!

Contributor

hexfusion commented May 23, 2018

Perfect thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment