From e07c91b422e524e04f3b88ef42cb4cada6a7ca7e Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 13 Jun 2023 11:19:20 +0200 Subject: [PATCH 1/5] Prepare release of `3.2.0` --- .github/workflows/publish.yaml | 9 +++++++++ CHANGELOG.md | 2 +- lib/src/server/server.dart | 15 --------------- pubspec.yaml | 2 +- 4 files changed, 11 insertions(+), 17 deletions(-) create mode 100644 .github/workflows/publish.yaml diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml new file mode 100644 index 00000000..f0ad5a87 --- /dev/null +++ b/.github/workflows/publish.yaml @@ -0,0 +1,9 @@ +name: Publish +on: + pull_request: + branches: [ main ] + push: + tags: [ '[0-9]+.[0-9]+.[0-9]+' ] +jobs: + publish: + uses: dart-lang/ecosystem/.github/workflows/publish.yml@main \ No newline at end of file diff --git a/CHANGELOG.md b/CHANGELOG.md index ad66e0f5..5a5925b8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,4 @@ -## 3.2.0-dev +## 3.2.0 * `ChannelOptions` now exposes `connectTimeout`, which is used on the socket connect. This is used to specify the maximum allowed time to wait diff --git a/lib/src/server/server.dart b/lib/src/server/server.dart index f6c55962..11b41ee2 100644 --- a/lib/src/server/server.dart +++ b/lib/src/server/server.dart @@ -163,15 +163,6 @@ class Server extends ConnectionServer { ServerSocket? _insecureServer; SecureServerSocket? _secureServer; - /// Create a server for the given [services]. - @Deprecated('use Server.create() instead') - Server( - super.services, [ - super.interceptors, - super.codecRegistry, - super.errorHandler, - ]); - /// Create a server for the given [services]. Server.create({ required List services, @@ -280,12 +271,6 @@ class Server extends ConnectionServer { )..handle(); } - @Deprecated( - 'This is internal functionality, and will be removed in next major version.') - void serveStream(ServerTransportStream stream) { - serveStream_(stream: stream); - } - Future shutdown() async { final done = _connections.map((connection) => connection.finish()).toList(); if (_insecureServer != null) { diff --git a/pubspec.yaml b/pubspec.yaml index b1847139..9bf0efa1 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,7 +1,7 @@ name: grpc description: Dart implementation of gRPC, a high performance, open-source universal RPC framework. -version: 3.2.0-dev +version: 3.2.0 repository: https://github.com/grpc/grpc-dart From c689ba383d3665c250f483d832d77d9da1e7a3dd Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 13 Jun 2023 12:31:58 +0200 Subject: [PATCH 2/5] Add newline --- .github/workflows/publish.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml index f0ad5a87..7ae4e98b 100644 --- a/.github/workflows/publish.yaml +++ b/.github/workflows/publish.yaml @@ -6,4 +6,4 @@ on: tags: [ '[0-9]+.[0-9]+.[0-9]+' ] jobs: publish: - uses: dart-lang/ecosystem/.github/workflows/publish.yml@main \ No newline at end of file + uses: dart-lang/ecosystem/.github/workflows/publish.yml@main From 50a31df269a12804fbcdc251da3ef6add6df42cb Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 13 Jun 2023 12:33:25 +0200 Subject: [PATCH 3/5] Do not change API outside of major version rev --- lib/src/server/server.dart | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/lib/src/server/server.dart b/lib/src/server/server.dart index 11b41ee2..f6c55962 100644 --- a/lib/src/server/server.dart +++ b/lib/src/server/server.dart @@ -163,6 +163,15 @@ class Server extends ConnectionServer { ServerSocket? _insecureServer; SecureServerSocket? _secureServer; + /// Create a server for the given [services]. + @Deprecated('use Server.create() instead') + Server( + super.services, [ + super.interceptors, + super.codecRegistry, + super.errorHandler, + ]); + /// Create a server for the given [services]. Server.create({ required List services, @@ -271,6 +280,12 @@ class Server extends ConnectionServer { )..handle(); } + @Deprecated( + 'This is internal functionality, and will be removed in next major version.') + void serveStream(ServerTransportStream stream) { + serveStream_(stream: stream); + } + Future shutdown() async { final done = _connections.map((connection) => connection.finish()).toList(); if (_insecureServer != null) { From 7b6d767c6b85f0c2377cef41f7a8bc9f20dfdc9b Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 13 Jun 2023 12:35:38 +0200 Subject: [PATCH 4/5] Change `main` to `master` in workflow --- .github/workflows/publish.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml index 7ae4e98b..baa7eb66 100644 --- a/.github/workflows/publish.yaml +++ b/.github/workflows/publish.yaml @@ -1,7 +1,7 @@ name: Publish on: pull_request: - branches: [ main ] + branches: [ master ] push: tags: [ '[0-9]+.[0-9]+.[0-9]+' ] jobs: From d255e4cdfc1f20489f5eb84e911def891dabc2b3 Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 13 Jun 2023 12:38:01 +0200 Subject: [PATCH 5/5] yml -> yaml --- .github/workflows/publish.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml index baa7eb66..8ad3deca 100644 --- a/.github/workflows/publish.yaml +++ b/.github/workflows/publish.yaml @@ -6,4 +6,4 @@ on: tags: [ '[0-9]+.[0-9]+.[0-9]+' ] jobs: publish: - uses: dart-lang/ecosystem/.github/workflows/publish.yml@main + uses: dart-lang/ecosystem/.github/workflows/publish.yaml@main