-
Notifications
You must be signed in to change notification settings - Fork 281
Update protos #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update protos #812
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
|
Thanks! Would be good to also mention in the commit message that the protoc_plugin version is updated. (I think generated files should mention the protoc_plugin version used, but we don't do it yet.) |
PR HealthAPI leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
|
Hm, this seems to be a breaking change with |
|
Good catch. Yes, that's expected, if the protos are exposed we should bump the major version. In the changelog we can mention that users should use |
|
@mosuem I also just noticed that the current version has the minimum protobuf bound of 5.0.0, but 5.0.0 has a bug, see the last entry here: https://github.com/google/protobuf.dart/blob/master/protobuf/CHANGELOG.md#510 We should also update it to 5.1.0 to make sure users will use at least 5.1.0 or newer and have the bug fix. |
|
I am wondering why the protos are exposed at all. I think they shouldn't be. I will try to remove the export, which is breaking in itself - I think I added them a while back for some g3 error. Let's see. |
Upgrading protos with new
googleapisandprotobufversions.Recreation of #811 .