Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required changes for 3.0.0 preview3 #112

Merged
merged 14 commits into from Feb 21, 2019

Conversation

Projects
None yet
7 participants
@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Feb 20, 2019

I noticed a few changes in preview3 and updated our code accordingly.

@JunTaoLuo JunTaoLuo requested review from JamesNK and jtattermusch Feb 20, 2019

Show resolved Hide resolved global.json

@JunTaoLuo JunTaoLuo force-pushed the JunTaoLuo:preview3-fixes branch from ca56e40 to 9e5feb6 Feb 20, 2019

@jtattermusch
Copy link
Contributor

jtattermusch left a comment

approved, but we need to figure out the question of depending on daily build vs. depending on a released version.
We definitely need a test that makes sure that everything is working against the latest released version (preview2 for now, preview3 soon). I'm not sure about the importance of testing against the unreleased version of .NET core - that depends on how often we will need access to new APIs and fixes (hopefully not often because the thing needs to work for users with preview3 anyway?). If we need both, we should have two tests.

Show resolved Hide resolved .travis.yml Outdated

JamesNK and others added some commits Feb 20, 2019

Update test/Grpc.AspNetCore.Server.Tests/GrpcEndpointRouteBuilderExte…
…nsionsTests.cs

Co-Authored-By: JunTaoLuo <johluo@microsoft.com>
Update test/Grpc.AspNetCore.Server.Tests/GrpcEndpointRouteBuilderExte…
…nsionsTests.cs

Co-Authored-By: JunTaoLuo <johluo@microsoft.com>
@JunTaoLuo

This comment has been minimized.

Copy link
Contributor Author

JunTaoLuo commented Feb 20, 2019

JunTaoLuo added some commits Feb 20, 2019

JunTaoLuo added some commits Feb 21, 2019

@JunTaoLuo JunTaoLuo merged commit c7ca9ce into grpc:master Feb 21, 2019

2 checks passed

cla/linuxfoundation JunTaoLuo authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@JunTaoLuo JunTaoLuo deleted the JunTaoLuo:preview3-fixes branch Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.