Skip to content

Conversation

@pengweiqhca
Copy link
Contributor

@pengweiqhca pengweiqhca commented Jan 12, 2022

Fix #1558

@JamesNK
Copy link
Member

JamesNK commented Jan 12, 2022

Thanks. Is there a way to unit test this? A unit test will prevent another regression.

@JamesNK JamesNK changed the title Fix #1558 Fix different activitiy types sent to diagnostic source Jan 13, 2022
@JamesNK JamesNK merged commit eb813a7 into grpc:master Jan 13, 2022
@JamesNK
Copy link
Member

JamesNK commented Jan 13, 2022

I updated the unit test a bit.

Thanks for raising this bug and the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#1465 break change: not support OpenTelemetry.Instrumentation.GrpcNetClient

2 participants