From 0b23381feda838659eab4aad904410244dd0a316 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mustafa=20=C5=9EEN?= Date: Tue, 9 Jan 2024 21:46:10 +0300 Subject: [PATCH] Address reviews --- internal/transport/transport_test.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/internal/transport/transport_test.go b/internal/transport/transport_test.go index ab7c0e6508e..ff27678294f 100644 --- a/internal/transport/transport_test.go +++ b/internal/transport/transport_test.go @@ -2152,13 +2152,14 @@ func (s) TestWriteHeaderConnectionError(t *testing.T) { return false, nil }) + server.mu.Lock() + if len(server.conns) != 1 { t.Fatalf("Server has %d connections from the client, want 1", len(server.conns)) } // Get the server transport for the connecton to the client. var serverTransport *http2Server - server.mu.Lock() for k := range server.conns { serverTransport = k.(*http2Server) } @@ -2173,7 +2174,7 @@ func (s) TestWriteHeaderConnectionError(t *testing.T) { t.Fatalf("Client failed to create first stream. Err: %v", err) } - <-notifyChan // Wait server stream to be established. + <-notifyChan // Wait for server stream to be established. var sstream *Stream // Access stream on the server. serverTransport.mu.Lock() @@ -2189,7 +2190,7 @@ func (s) TestWriteHeaderConnectionError(t *testing.T) { client.Close(fmt.Errorf("closed manually by test")) - // Wait server transport to be closed. + // Wait for server transport to be closed. <-serverTransport.done // Write header on a closed server transport.