Skip to content
Branch: master
Commits on Nov 6, 2019
  1. cleanup: fix generic comparisons on protobuf messages (#3153)

    dsnet authored and menghanl committed Nov 6, 2019
    Generated protobuf messages contain internal data structures
    that general purpose comparison functions (e.g., reflect.DeepEqual,
    pretty.Compare, etc) do not properly compare. It is already the case
    today that these functions may report a difference when two messages
    are actually semantically equivalent.
    Fix all usages by either calling proto.Equal directly if
    the top-level types are themselves proto.Message, or by calling
    cmp.Equal with the cmp.Comparer(proto.Equal) option specified.
    This option teaches cmp to use proto.Equal anytime it encounters
    proto.Message types.
You can’t perform that action at this time.