Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UnknownServiceHandler comment to be clearer about interceptor behavior #1566

Merged
merged 1 commit into from Oct 5, 2017
Merged

Update UnknownServiceHandler comment to be clearer about interceptor behavior #1566

merged 1 commit into from Oct 5, 2017

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Oct 5, 2017

No description provided.

@dfawley dfawley added the Type: Documentation Documentation or examples label Oct 5, 2017
@dfawley dfawley requested a review from menghanl October 5, 2017 20:58
menghanl
menghanl approved these changes Oct 5, 2017
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♒ 📢 👨 🏢 💺

@dfawley dfawley merged commit 5279edf into grpc:master Oct 5, 2017
menghanl added a commit that referenced this pull request Oct 6, 2017
@menghanl
Revert "Update UnknownServiceHandler comment to be clearer about inte…
1041085 
…rceptor behavior (#1566)"

This reverts commit 5279edf.
@menghanl menghanl added this to the 1.7 Release milestone Oct 11, 2017
dfawley added a commit that referenced this pull request Oct 16, 2017
@dfawley
Revert "Update UnknownServiceHandler comment to be clearer about inte…
f968856 
…rceptor behavior (#1566)"

This reverts commit 5279edf.
dfawley added a commit that referenced this pull request Oct 16, 2017
@dfawley
Revert "Update UnknownServiceHandler comment to be clearer about inte…
8d369dd 
…rceptor behavior (#1566)"

This reverts commit 5279edf.
@dfawley dfawley deleted the fix_comment branch April 30, 2018 16:11
@lock lock bot locked as resolved and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees

@menghanl menghanl

Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.7 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dfawley @menghanl