Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that all errors from RPCs are status errors #1782

Merged
merged 2 commits into from Jan 5, 2018

Conversation

@menghanl
Copy link
Contributor

@menghanl menghanl commented Jan 5, 2018

fixes #1581

@menghanl menghanl requested a review from dfawley Jan 5, 2018
call.go Outdated
@@ -138,6 +138,8 @@ func sendRequest(ctx context.Context, dopts dialOptions, compressor Compressor,

// Invoke sends the RPC request on the wire and returns after response is
// received. This is typically called by generated code.
//
// All errors returned by Invoke are status errors.

This comment has been minimized.

@dfawley

dfawley Jan 5, 2018
Contributor

How about "are errors compatible with the status package"?

This comment has been minimized.

@menghanl

menghanl Jan 5, 2018
Author Contributor

Done

2
@dfawley
dfawley approved these changes Jan 5, 2018
@menghanl menghanl merged commit 6913ad5 into grpc:master Jan 5, 2018
2 checks passed
2 checks passed
cla/linuxfoundation menghanl authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@menghanl menghanl deleted the menghanl:status_error_doc branch Jan 5, 2018
@menghanl menghanl added this to the 1.10 Release milestone Feb 14, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants