Throw an error for non-default DNS authority. #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gRPC naming document at https://github.com/grpc/grpc/blob/master/doc/naming.md says: > for DNS, the authority may include the IP[:port] of the DNS server to use However, grpc-go does not support configuring DNS servers. It will always use Go's default DNS resolver.
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
|
Hi @jsha, thanks for the pr, could you please sign the CLA? |
|
I've filled out the CLA now. |
lyuxuan
reviewed
Jun 1, 2018
resolver/dns/dns_resolver.go
Outdated
| @@ -67,6 +67,9 @@ type dnsBuilder struct { | |||
|
|
|||
| // Build creates and starts a DNS resolver that watches the name resolution of the target. | |||
| func (b *dnsBuilder) Build(target resolver.Target, cc resolver.ClientConn, opts resolver.BuildOption) (resolver.Resolver, error) { | |||
| if target.Authority != "" { | |||
| return nil, fmt.Errorf("non-default DNS resolver %q not supported", target.Authority) | |||
There was a problem hiding this comment.
Could you please change the error message to "Default DNS resolver does not support custom DNS server"? Thanks!
lyuxuan
approved these changes
Jun 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gRPC naming document at
https://github.com/grpc/grpc/blob/master/doc/naming.md says:
However, grpc-go does not support configuring DNS servers. It will always use
Go's default DNS resolver.