Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upclient: fix handling of GRPC_GO_REQUIRE_HANDSHAKE=on to not interpret as "hybrid" #2603
Conversation
This comment has been minimized.
This comment has been minimized.
thelinuxfoundation
commented
Jan 29, 2019
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
dfawley
changed the title
|
Good catch, thank you for the fix. Please sign the CLAs so we can merge this. EDIT: looks like the CLA bot is happy now. Thanks again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dntj commentedJan 29, 2019
6cc789b made
envconfig.RequireHandshakeOnthe default when unspecified by environment variable, but missed a fallthrough leading toGRPC_GO_REQUIRE_HANDSHAKE=onspecifyingenvconfig.RequireHandshakeHybrid. This change adds the missing fallthrough.