Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix handling of GRPC_GO_REQUIRE_HANDSHAKE=on to not interpret as "hybrid" #2603

Merged
merged 1 commit into from Jan 29, 2019

Conversation

@dntj
Copy link
Contributor

dntj commented Jan 29, 2019

6cc789b made envconfig.RequireHandshakeOn the default when unspecified by environment variable, but missed a fallthrough leading to GRPC_GO_REQUIRE_HANDSHAKE=on specifying envconfig.RequireHandshakeHybrid. This change adds the missing fallthrough.

6cc789b made `envconfig.RequireHandshakeOn` the default when unspecified by environment variable, but missed a fallthrough leading to `GRPC_GO_REQUIRE_HANDSHAKE=on` specifying `envconfig.RequireHandshakeHybrid`.
@thelinuxfoundation

This comment has been minimized.

Copy link

thelinuxfoundation commented Jan 29, 2019

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@dfawley dfawley self-assigned this Jan 29, 2019
@dfawley dfawley self-requested a review Jan 29, 2019
@dfawley dfawley added the Type: Bug label Jan 29, 2019
@dfawley dfawley added this to the 1.19 Release milestone Jan 29, 2019
@dfawley dfawley changed the title fix: envconfig.RequireHandshake initialization when `on`. client: fix handling of GRPC_GO_REQUIRE_HANDSHAKE=on to not interpret as "hybrid" Jan 29, 2019
Copy link
Contributor

dfawley left a comment

Good catch, thank you for the fix. Please sign the CLAs so we can merge this.

EDIT: looks like the CLA bot is happy now. Thanks again.

@dfawley dfawley merged commit eda3b7e into grpc:master Jan 29, 2019
2 checks passed
2 checks passed
cla/linuxfoundation dntj authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lock lock bot locked as resolved and limited conversation to collaborators Jul 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.