Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental comment from client interceptors #3948

Merged

Conversation

@hypnoglow
Copy link
Contributor

@hypnoglow hypnoglow commented Oct 10, 2020

As proposed per #3693, this change removes comments stating that client interceptors API are still experimental.

I added additional commentary on parameters and return values etc. as far as I understand them. Please let me know if we need to rephrase/add/remove those comments.

@hypnoglow
Copy link
Contributor Author

@hypnoglow hypnoglow commented Oct 10, 2020

/assign @dfawley

Copy link
Contributor

@easwars easwars left a comment

Thank you very much for the PR.

interceptor.go Outdated Show resolved Hide resolved
interceptor.go Outdated Show resolved Hide resolved
interceptor.go Outdated Show resolved Hide resolved
@hypnoglow hypnoglow force-pushed the interceptors-not-experimental-anymore branch from b233f66 to ac379eb Oct 24, 2020
@hypnoglow
Copy link
Contributor Author

@hypnoglow hypnoglow commented Oct 24, 2020

@easwars Thank you for the review. Updated the comments and wrapped at 80 cols.

@hypnoglow hypnoglow requested a review from easwars Oct 24, 2020
Copy link
Contributor

@easwars easwars left a comment

Thank you very much for the PR.

@easwars easwars merged commit e8e2287 into grpc:master Oct 26, 2020
3 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants