Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpclb: consider IDLE SubConns as connecting #4031

Merged
merged 2 commits into from Nov 16, 2020

Conversation

@menghanl
Copy link
Contributor

@menghanl menghanl commented Nov 12, 2020

Otherwise, when the first response is received from the grpclb server, the
parent ClientConn enters TransientFailure, and the first several
non-wait-for-ready RPCs will fail.

fixes #4029

Otherwise, when the first response is received from the grpclb server, the
parent ClientConn enters TransientFailure, and the first several
non-wait-for-ready RPCs will fail.
@@ -298,7 +298,7 @@ func (lb *lbBalancer) aggregateSubConnStates() connectivity.State {
switch state {
case connectivity.Ready:
return connectivity.Ready
case connectivity.Connecting:
case connectivity.Connecting, connectivity.Idle:

Can you also update the func comments above?

Copy link
Contributor Author

@menghanl menghanl Nov 12, 2020

Done

@menghanl menghanl merged commit 1d01bf9 into grpc:master Nov 16, 2020
11 checks passed
@menghanl menghanl deleted the grpclb_start_connecting branch Nov 16, 2020
davidkhala added a commit to Hyperledger-TWGC/grpc that referenced this issue Dec 7, 2020
Otherwise, when the first response is received from the grpclb server, the
parent ClientConn enters TransientFailure, and the first several
non-wait-for-ready RPCs will fail.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants