Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds/priority: handle new low priority when high priority is in Idle #4889

Merged
merged 1 commit into from Oct 20, 2021

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Oct 19, 2021

This change makes sure we don't switch to the new low priority if high
priority is Idle.

RELEASE NOTES:

  • xds/priority: do not switch to low priority when high priority is in Idle (e.g. ringhash)

…priority is in Idle

This change makes sure we don't switch to the new low priority if high
priority is Idle.
@menghanl menghanl requested a review from dfawley Oct 19, 2021
@menghanl menghanl added this to the 1.42 Release milestone Oct 19, 2021
@dfawley dfawley assigned menghanl and unassigned dfawley Oct 20, 2021
@menghanl menghanl merged commit 0d50307 into grpc:master Oct 20, 2021
10 checks passed
@menghanl menghanl deleted the priority_IDLE_more branch Oct 20, 2021
gcf-merge-on-green bot pushed a commit to googleapis/google-api-go-client that referenced this issue Oct 28, 2021
DirectPath is migrating to Traffic Director, and we want to setup E2E tests based on TD for Bigtable and Spanner. This PR:
1. Update grpc-go version to 1.41.0, which has RING_HASH LB policy support;
2. Add the google-c2p resolver dependence to google-api-go-client;
3. Add an environment variable GOOGLE_CLOUD_ENABLE_DIRECT_PATH_XDS to enable using DirectPath over TD;
Corresponding PR in gax-java: googleapis/gax-java#1521.

Also note that currently there is a bug in grpc-go, and fix is grpc/grpc-go#4889. I have verified that with this fix Bigtable E2E test over DirectPath Traffic Director can pass. This PR has been merged to grpc-go and will release in grpc-go 1.42.0, which will be the minimal version for supporting `google-c2p` URI scheme.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants