Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds/client: send NewStream errors to the watchers #5032

Merged
merged 1 commit into from Dec 8, 2021

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Dec 1, 2021

fixes #5020

RELEASE NOTES:

  • xds/client:notify watchers of errors creating new xDS stream

@menghanl menghanl requested a review from dfawley Dec 1, 2021
@menghanl menghanl added this to the 1.43 release milestone Dec 1, 2021
@dfawley dfawley removed this from the 1.43 release milestone Dec 6, 2021
@dfawley dfawley added this to the 1.44 Release milestone Dec 6, 2021
dfawley
dfawley approved these changes Dec 7, 2021
@dfawley dfawley assigned menghanl and unassigned dfawley Dec 7, 2021
@menghanl menghanl merged commit 1ec7a89 into grpc:master Dec 8, 2021
10 checks passed
@menghanl menghanl deleted the xds_client_new_stream_error branch Dec 8, 2021
easwars pushed a commit to easwars/grpc-go that referenced this issue Dec 14, 2021
@easwars easwars mentioned this pull request Dec 14, 2021
@easwars easwars removed this from the 1.44 Release milestone Dec 14, 2021
@easwars easwars added this to the 1.43 release milestone Dec 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants