Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authz: fix regex expression match #5035

Merged
merged 5 commits into from Dec 9, 2021
Merged

authz: fix regex expression match #5035

merged 5 commits into from Dec 9, 2021

Conversation

ashithasantosh
Copy link
Contributor

@ashithasantosh ashithasantosh commented Dec 2, 2021

In SDK authorization policy, "*" value represents presence match i.e. it will match when the value is not empty. This PR fixes presence match. Additionally, it updates underlying regex code to correctly handle match with empty string values.

RELEASE NOTES:

  • authz: fixes regex expression match

@ashithasantosh ashithasantosh requested a review from dfawley Dec 2, 2021
@ashithasantosh ashithasantosh added this to the 1.43 release milestone Dec 2, 2021
@ashithasantosh ashithasantosh changed the title Fixes regex expression matching authz: fixes regex expression match Dec 2, 2021
authz/rbac_translator.go Outdated Show resolved Hide resolved
@dfawley dfawley removed this from the 1.43 release milestone Dec 6, 2021
@dfawley dfawley added this to the 1.44 Release milestone Dec 6, 2021
@dfawley dfawley changed the title authz: fixes regex expression match authz: fix regex expression match Dec 7, 2021
@dfawley dfawley assigned ashithasantosh and unassigned dfawley Dec 7, 2021
internal/grpcutil/regex.go Outdated Show resolved Hide resolved
authz/rbac_translator.go Outdated Show resolved Hide resolved
dfawley
dfawley approved these changes Dec 9, 2021
@dfawley dfawley assigned ashithasantosh and unassigned dfawley Dec 9, 2021
@ashithasantosh ashithasantosh removed their assignment Dec 9, 2021
@ashithasantosh ashithasantosh merged commit 5d90b32 into grpc:master Dec 9, 2021
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants