Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpclog.DepthLoggerV2: Correct comment: formats like fmt.Println #5038

Merged
merged 1 commit into from Dec 7, 2021

Conversation

evanj
Copy link
Contributor

@evanj evanj commented Dec 6, 2021

The documentation comments stated that arguments were handled like
fmt.Print, when they are actually handled like fmt.Println. For
example, the "fallback" implementation in
internal/grpclog/grpclog.go for InfoDepth calls Logger.Infoln.

RELEASE NOTES: N/A

The documentation comments stated that arguments were handled like
fmt.Print, when they are actually handled like fmt.Println. For
example, the "fallback" implementation in
internal/grpclog/grpclog.go for InfoDepth calls Logger.Infoln.
@evanj evanj force-pushed the evan.jones/depthlogger-comment branch from 36c5ae3 to ba111d0 Compare Dec 6, 2021
@dfawley dfawley added this to the 1.44 Release milestone Dec 6, 2021
@menghanl menghanl requested review from menghanl and dfawley Dec 7, 2021
@menghanl menghanl added the Type: Documentation label Dec 7, 2021
dfawley
dfawley approved these changes Dec 7, 2021
@dfawley dfawley merged commit ccc060c into grpc:master Dec 7, 2021
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants