Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls: control channel implementation #5046

Merged
merged 11 commits into from Dec 15, 2021
Merged

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Dec 7, 2021

Summary of changes:

  • Implementation of the control channel to the RLS server
    • This includes the control channel connectivity state monitoring as well
  • Removed most of the existing code in the builder, balancer, picker, and rls client
    • Most of this is changing beyond recognition anyways
    • Without removing existing changes and making them boiler plate, it was not possible to break the massive PR into anything reasonable
  • Bunch of test helper functionality
    • Not all of that might be used by the tests in this PR, but selectively adding them was another pain point.

Full implementation is at #4992

RELEASE NOTES: none

@easwars easwars added this to the 1.44 Release milestone Dec 7, 2021
@easwars easwars force-pushed the rls_control_channel_changes branch from f25b5cb to a98dcd0 Compare Dec 7, 2021
@easwars easwars force-pushed the rls_control_channel_changes branch from a98dcd0 to a7b31c6 Compare Dec 7, 2021
@easwars
Copy link
Contributor Author

@easwars easwars commented Dec 7, 2021

This PR is still huge, but the code under concern is mostly limited to control_channel.go and control_channel_test.go. Most of the rest of removing old code and some test wrappers which will be used much more in upcoming PRs.

@dfawley
Copy link
Contributor

@dfawley dfawley commented Dec 8, 2021

/easycla

internal/testutils/restartable_listener.go Show resolved Hide resolved
internal/stubserver/stubserver.go Outdated Show resolved Hide resolved
balancer/rls/internal/control_channel.go Outdated Show resolved Hide resolved
balancer/rls/internal/control_channel.go Outdated Show resolved Hide resolved
balancer/rls/internal/control_channel.go Outdated Show resolved Hide resolved
balancer/rls/internal/control_channel.go Outdated Show resolved Hide resolved
balancer/rls/internal/control_channel.go Outdated Show resolved Hide resolved
balancer/rls/internal/control_channel.go Outdated Show resolved Hide resolved
balancer/rls/internal/control_channel.go Outdated Show resolved Hide resolved
@easwars
Copy link
Contributor Author

@easwars easwars commented Dec 9, 2021

Thanks for the review.

balancer/rls/internal/control_channel.go Outdated Show resolved Hide resolved
balancer/rls/internal/control_channel.go Outdated Show resolved Hide resolved
internal/stubserver/stubserver.go Outdated Show resolved Hide resolved
internal/testutils/restartable_listener.go Show resolved Hide resolved
balancer/rls/internal/control_channel.go Outdated Show resolved Hide resolved
@dfawley dfawley assigned easwars and unassigned dfawley Dec 9, 2021
@easwars easwars assigned dfawley and unassigned easwars Dec 10, 2021
@dfawley dfawley assigned easwars and unassigned dfawley Dec 13, 2021
@easwars easwars assigned dfawley and unassigned easwars Dec 13, 2021
@dfawley dfawley assigned easwars and unassigned dfawley Dec 15, 2021
@easwars easwars merged commit 50f8270 into grpc:master Dec 15, 2021
10 checks passed
@easwars easwars deleted the rls_control_channel_changes branch Dec 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants