Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authz: update representation of allow authenticated in SDK #5052

Merged

Conversation

ashithasantosh
Copy link
Contributor

@ashithasantosh ashithasantosh commented Dec 10, 2021

With the changes in this PR, allow authenticated can be represented using principals: ["*", ""] instead of principals: [].
This way we can avoid special semantics.

Related discussion
grpc/proposal#246 (comment)

RELEASE NOTES:

  • authz: update representation of allow authenticated in SDK

@ashithasantosh ashithasantosh marked this pull request as draft Dec 10, 2021
@ashithasantosh ashithasantosh added this to the 1.44 Release milestone Dec 14, 2021
@ashithasantosh ashithasantosh marked this pull request as ready for review Dec 14, 2021
@ashithasantosh ashithasantosh requested a review from dfawley Dec 14, 2021
@easwars easwars self-assigned this Dec 15, 2021
authz/rbac_translator.go Outdated Show resolved Hide resolved
authz/sdk_end2end_test.go Show resolved Hide resolved
authz/rbac_translator_test.go Show resolved Hide resolved
@easwars easwars assigned ashithasantosh and unassigned easwars Dec 21, 2021
@easwars
Copy link
Contributor

@easwars easwars commented Dec 21, 2021

@zasweq

@ashithasantosh
Copy link
Contributor Author

@ashithasantosh ashithasantosh commented Dec 28, 2021

Thank you for the review!:)

@ashithasantosh ashithasantosh merged commit fbaf7c5 into grpc:master Dec 28, 2021
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants