Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: minor improvement on WithInsecure() document #5068

Merged
merged 1 commit into from Dec 22, 2021

Conversation

shitian-ni
Copy link
Contributor

@shitian-ni shitian-ni commented Dec 17, 2021

Current document asks to replace WithInsecure() with insecure.NewCredentials().
But it causes confusion because function signatures for WithInsecure() and insecure.NewCredentials() are different.

Instead, using insecure.NewCredentials() as a parameter for WithTransportCredentials replicate the deprecated WithInsecure function.

So I propose a minor improvement to mention WithTransportCredentials in the comment.

RELEASE NOTES: None

@linux-foundation-easycla
Copy link

@linux-foundation-easycla linux-foundation-easycla bot commented Dec 17, 2021

CLA Signed

The committers are authorized under a signed CLA.

@dfawley dfawley requested a review from easwars Dec 22, 2021
@easwars easwars added the Type: Documentation label Dec 22, 2021
@easwars easwars added this to the 1.44 Release milestone Dec 22, 2021
@easwars easwars merged commit 8ae11f4 into grpc:master Dec 22, 2021
10 checks passed
@shitian-ni shitian-ni deleted the improve-insecure-doc branch Dec 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants