Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls: use UNAVAILABLE instead of status from control plane #5400

Merged

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Jun 3, 2022

RELEASE NOTES:

  • RLS load balancer: don't propagate the status code returned on control plane RPCs to data plane RPCs

@easwars easwars added the Type: Behavior Change Behavior changes not categorized as bugs label Jun 3, 2022
@easwars easwars added this to the 1.48 Release milestone Jun 3, 2022
@easwars easwars requested a review from dfawley June 3, 2022 18:44
// the status code sent by the control plane. Propagating the status
// message received from the control plane is still fine, as it could be
// useful for debugging purposes.
return p.useDefaultPickIfPossible(info, status.Error(codes.Unavailable, st.Error()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we prefix the error string with a message indicating the source of the error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dfawley dfawley assigned easwars and unassigned dfawley Jun 3, 2022
@easwars easwars assigned dfawley and unassigned easwars Jun 6, 2022
@dfawley dfawley added Type: Bug and removed Type: Behavior Change Behavior changes not categorized as bugs labels Jun 6, 2022
dfawley
dfawley approved these changes Jun 6, 2022
@dfawley dfawley assigned easwars and unassigned dfawley Jun 6, 2022
@easwars easwars merged commit 34e4fc3 into grpc:master Jun 6, 2022
11 checks passed
@easwars easwars deleted the rls_dont_propogate_status_from_control_plane branch June 14, 2022 21:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants