Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport: remove unused bufWriter.onFlush() #5464

Merged
merged 1 commit into from Jun 28, 2022
Merged

Conversation

mitchsw
Copy link
Contributor

@mitchsw mitchsw commented Jun 23, 2022

The bufWriter.onFlush() feature was not used in the initial bufWriter PR #1962 from four years ago. It is unclear if there were future plans, but it is clearly not needed today.

RELEASE NOTES: none

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 23, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@mitchsw
Copy link
Contributor Author

mitchsw commented Jun 24, 2022

CLA now covered :)

@easwars easwars added the Type: Internal Cleanup Refactors, etc label Jun 24, 2022
@easwars easwars added this to the 1.48 Release milestone Jun 24, 2022
@dfawley dfawley changed the title Remove unused bufWriter.onFlush() transport: remove unused bufWriter.onFlush() Jun 28, 2022
@dfawley dfawley merged commit c9b16c8 into grpc:master Jun 28, 2022
11 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants