Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: drop localities with zero weight at the xdsClient layer #5476

Merged
merged 2 commits into from Jun 30, 2022

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Jun 30, 2022

Fixes #5453

This PR moves the logic of dropping localities, in a received EDS response with weight 0, to the xdsClient. This allows the LB policy implementations to function with the assumption that they would only receive localities with non-zero weights as part of any updates from the xdsClient. This mirrors C-core behavior.

RELEASE NOTES: none

@easwars easwars requested review from dfawley and zasweq June 30, 2022 00:29
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Jun 30, 2022
@easwars easwars added this to the 1.48 Release milestone Jun 30, 2022
@dfawley dfawley assigned easwars and unassigned dfawley Jun 30, 2022
@easwars easwars merged commit 5770b1d into grpc:master Jun 30, 2022
11 checks passed
@easwars easwars deleted the zero_weight_localities branch July 15, 2022 17:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xdsclient: skip localities with zero weight when parsing the resource
3 participants