Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: prevent a nil stats handler from causing a panic #5543

merged 4 commits into from Jul 29, 2022


Copy link

@dfawley dfawley commented Jul 28, 2022

Fix #5512


  • Fix a panic caused by passing a nil stats handler to grpc.WithStatsHandler or grpc.StatsHandler

@dfawley dfawley added this to the 1.49 Release milestone Jul 28, 2022
@dfawley dfawley requested a review from easwars July 28, 2022 20:57
dialoptions.go Show resolved Hide resolved
server.go Show resolved Hide resolved
@easwars easwars assigned dfawley and unassigned easwars Jul 28, 2022
Copy link

easwars commented Jul 28, 2022

Hope you have better luck with the tests !!

Copy link
Contributor Author

dfawley commented Jul 29, 2022

Hope you have better luck with the tests !!

Oops, the failures are caused by this change - we had a test that was unnecessarily adding a nil stats handler in order to test something unrelated.

@dfawley dfawley merged commit 02f1a7a into grpc:master Jul 29, 2022
11 checks passed
@dfawley dfawley deleted the nil_stats_handler branch July 29, 2022 17:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

panic: runtime error: invalid memory address or nil pointer dereference at grpc@v1.48.0/stream.go:380
2 participants