Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

priority: sync priority with child in use #5549

merged 1 commit into from Aug 1, 2022


Copy link

@easwars easwars commented Aug 1, 2022

Recently, we added functionality to push config updates to all child policies (not just the active one) and process all child picker updates before determining active priority. See: #5417

As part of this change though, we were calling syncPriority with an empty child name at the end of the config processing pipeline. This sometimes could lead to the priority LB policy dropping picker updates which could lead to all RPCs getting blocked.


  • priority: fix bug which could cause priority LB from blocking all traffic after a config update

@easwars easwars requested a review from zasweq August 1, 2022 21:38
@easwars easwars added this to the 1.49 Release milestone Aug 1, 2022
Copy link

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@zasweq zasweq assigned easwars and unassigned zasweq Aug 1, 2022
@easwars easwars merged commit 23f015c into grpc:master Aug 1, 2022
11 checks passed
@easwars easwars deleted the sync_priority_fix branch August 1, 2022 23:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants