Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds/xdsclient: add sum of EDS locality weights check #5703

Merged
merged 2 commits into from Oct 10, 2022
Merged

xds/xdsclient: add sum of EDS locality weights check #5703

merged 2 commits into from Oct 10, 2022

Conversation

erni27
Copy link
Contributor

@erni27 erni27 commented Oct 7, 2022

This PR adds a check if sum of weights of the localities at the same priority level does not exceed maximal value (MaxUint32).

Fixes #5699

RELEASE NOTES:

  • xds/xdsclient: comply with spec to ensure sum of the weights of all EDS localities at the same priority level does not exceed uint32_t maximal value

@erni27 erni27 marked this pull request as ready for review October 7, 2022 23:06
@erni27
Copy link
Contributor Author

erni27 commented Oct 7, 2022

It's review-ready. I can use your help with proper tagging and filling the release notes. Also, seems like my changes don't affect the tests but they fail anyway, is it common? @easwars

@easwars easwars added this to the 1.51 Release milestone Oct 10, 2022
@easwars
Copy link
Contributor

easwars commented Oct 10, 2022

It's review-ready. I can use your help with proper tagging and filling the release notes. Also, seems like my changes don't affect the tests but they fail anyway, is it common? @easwars

Some of our tests are flaky and we are working towards fixing them. I added the proper tags and re-ran the tests and they pass now.

@erni27 erni27 requested a review from easwars October 10, 2022 16:33
@dfawley dfawley changed the title xds: add sum of weights check xds/xdsclient: add sum of EDS locality weights check Oct 10, 2022
@dfawley dfawley merged commit c672451 into grpc:master Oct 10, 2022
11 checks passed
@dfawley
Copy link
Contributor

dfawley commented Oct 10, 2022

Thank you for the PR @erni27!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xds: NACK EDS resource if locality weights sum to greater than MaxUint32
3 participants