Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade x/text to v0.4 to address CVE #5769

Merged
merged 4 commits into from Nov 7, 2022
Merged

Conversation

dfawley
Copy link
Contributor

@dfawley dfawley commented Nov 4, 2022

RELEASE NOTES:

@dfawley dfawley added this to the 1.51 Release milestone Nov 4, 2022
easwars
easwars approved these changes Nov 4, 2022
zasweq
zasweq approved these changes Nov 4, 2022
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zasweq
Copy link
Contributor

zasweq commented Nov 4, 2022

It's failing all the tests and vet.

@easwars
Copy link
Contributor

easwars commented Nov 4, 2022

Tests aren't happy though:

go: google.golang.org/grpc@v1.46.0 requires
	golang.org/x/sys@v0.0.0-20220722155257-8c9f86f7a55f: missing go.sum entry; to add it:
	go mod download golang.org/x/sys

@easwars easwars assigned dfawley and unassigned easwars and zasweq Nov 4, 2022
@dfawley dfawley merged commit 824f449 into grpc:master Nov 7, 2022
11 checks passed
@dfawley dfawley deleted the textver branch November 7, 2022 15:51
jronak pushed a commit to jronak/grpc-go that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants