Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflection: generate protobuf files from grpc-proto #5799

Merged
merged 2 commits into from Nov 21, 2022

Conversation

buzzsurfr
Copy link
Contributor

@buzzsurfr buzzsurfr commented Nov 16, 2022

Update regenerate.sh (which creates the generated protobuf go files in the repo) to instead pull the proto files from grpc/grpc-proto and remove the cached copies of the proto files.

Now, generated files are sourced from the v1alpha and v1 versions.

RELEASE NOTES: none

@easwars easwars added this to the 1.52 Release milestone Nov 17, 2022
@easwars
Copy link
Contributor

easwars commented Nov 17, 2022

@dfawley : For second set of eyes.

@dfawley dfawley changed the title Pull in reflection protobuf files from grpc-proto reflection: generate protobuf files from grpc-proto Nov 21, 2022
@dfawley dfawley merged commit 6e43203 into grpc:master Nov 21, 2022
1 check passed
@buzzsurfr buzzsurfr deleted the pull-from-grpc-proto branch December 18, 2022 16:37
camh- pushed a commit to foxygoat/jig that referenced this pull request Mar 12, 2023
Update our dependencies to be compatible with the current latest release
of `google.golang.org/genproto` by running:

    go get google.golang.org/genproto
    go mod tidy

This has broken a couple of small things, which are fixed here:

* The generated var name for the embedded protobuf descriptors has
  changed, so when `google.golang.org/grpc` got updated due to the
  genproto update, `reflection/service.go` needed to be updated with
  the new name. This was changed in grpc/grpc-go#5799.
  The var name changed because its proto import changed as part of that
  PR, and the var name is based on the import name.

* The error message for when `SendHeader` is called multiple times on a
  stream has changed which broke a test that was testing the error type
  and string. This was changed upstream in grpc/grpc-go#5292.

Link: grpc/grpc-go#5799
Link: grpc/grpc-go#5292
Pull-Request: #47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants