Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing godoc linter issues #7501

Closed
wants to merge 1 commit into from

Conversation

janardhanvissa
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.48%. Comparing base (ec9dff7) to head (3f34a87).
Report is 26 commits behind head on master.

Files Patch % Lines
xds/internal/httpfilter/rbac/rbac.go 50.00% 0 Missing and 2 partials ⚠️
xds/internal/httpfilter/router/router.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7501      +/-   ##
==========================================
- Coverage   81.56%   81.48%   -0.09%     
==========================================
  Files         354      358       +4     
  Lines       27076    27345     +269     
==========================================
+ Hits        22085    22281     +196     
- Misses       3802     3845      +43     
- Partials     1189     1219      +30     
Files Coverage Δ
balancer/pickfirst/pickfirst.go 83.73% <ø> (ø)
internal/stats/metrics_recorder_list.go 100.00% <ø> (ø)
internal/status/status.go 89.87% <100.00%> (ø)
orca/producer.go 96.20% <100.00%> (ø)
xds/internal/resolver/xds_resolver.go 80.71% <100.00%> (ø)
xds/internal/httpfilter/router/router.go 38.23% <50.00%> (ø)
xds/internal/httpfilter/rbac/rbac.go 63.15% <50.00%> (ø)

... and 43 files with indirect coverage changes

@janardhanvissa janardhanvissa mentioned this pull request Aug 12, 2024
13 tasks
@aranjans aranjans added the Type: Internal Cleanup Refactors, etc label Aug 13, 2024
@aranjans aranjans added this to the 1.66 Release milestone Aug 13, 2024
@aranjans aranjans self-requested a review August 13, 2024 09:11
@aranjans aranjans self-assigned this Aug 13, 2024
@purnesh42H purnesh42H removed the request for review from aranjans August 13, 2024 09:53
@purnesh42H
Copy link
Contributor

@janardhanvissa can you add the description of which linting issue this PR is fixing and what is the actual code change and how generated code change?

@purnesh42H
Copy link
Contributor

There will be a separate PR

@purnesh42H purnesh42H closed this Aug 14, 2024
@janardhanvissa janardhanvissa deleted the godocLinter branch September 16, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants