diff --git a/xds/src/main/java/io/grpc/xds/XdsClientImpl.java b/xds/src/main/java/io/grpc/xds/XdsClientImpl.java index 82addf72b3e..fb3524e4b61 100644 --- a/xds/src/main/java/io/grpc/xds/XdsClientImpl.java +++ b/xds/src/main/java/io/grpc/xds/XdsClientImpl.java @@ -53,7 +53,6 @@ import io.grpc.SynchronizationContext.ScheduledHandle; import io.grpc.internal.BackoffPolicy; import io.grpc.stub.StreamObserver; -import io.grpc.xds.Bootstrapper.ServerInfo; import io.grpc.xds.EnvoyProtoData.DropOverload; import io.grpc.xds.EnvoyProtoData.Locality; import io.grpc.xds.EnvoyProtoData.LocalityLbEndpoints; @@ -196,18 +195,14 @@ final class XdsClientImpl extends XdsClient { XdsClientImpl( String targetName, - List servers, // list of management servers - XdsChannelFactory channelFactory, + XdsChannel channel, Node node, SynchronizationContext syncContext, ScheduledExecutorService timeService, BackoffPolicy.Provider backoffPolicyProvider, Supplier stopwatchSupplier) { this.targetName = checkNotNull(targetName, "targetName"); - XdsChannel xdsChannel = - checkNotNull(channelFactory, "channelFactory") - .createChannel(checkNotNull(servers, "servers")); - this.xdsChannel = xdsChannel; + this.xdsChannel = checkNotNull(channel, "channel"); this.node = checkNotNull(node, "node"); this.syncContext = checkNotNull(syncContext, "syncContext"); this.timeService = checkNotNull(timeService, "timeService"); diff --git a/xds/src/test/java/io/grpc/xds/XdsClientImplTest.java b/xds/src/test/java/io/grpc/xds/XdsClientImplTest.java index b55a649741c..0c36fbe7f26 100644 --- a/xds/src/test/java/io/grpc/xds/XdsClientImplTest.java +++ b/xds/src/test/java/io/grpc/xds/XdsClientImplTest.java @@ -86,8 +86,6 @@ import io.grpc.internal.FakeClock.TaskFilter; import io.grpc.stub.StreamObserver; import io.grpc.testing.GrpcCleanupRule; -import io.grpc.xds.Bootstrapper.ChannelCreds; -import io.grpc.xds.Bootstrapper.ServerInfo; import io.grpc.xds.EnvoyProtoData.DropOverload; import io.grpc.xds.EnvoyProtoData.LbEndpoint; import io.grpc.xds.EnvoyProtoData.Locality; @@ -100,7 +98,6 @@ import io.grpc.xds.XdsClient.EndpointUpdate; import io.grpc.xds.XdsClient.EndpointWatcher; import io.grpc.xds.XdsClient.XdsChannel; -import io.grpc.xds.XdsClient.XdsChannelFactory; import io.grpc.xds.XdsClientImpl.MessagePrinter; import java.io.IOException; import java.util.ArrayDeque; @@ -279,23 +276,10 @@ public void cancelled(Context context) { channel = cleanupRule.register(InProcessChannelBuilder.forName(serverName).directExecutor().build()); - List servers = - ImmutableList.of(new ServerInfo(serverName, ImmutableList.of(), null)); - XdsChannelFactory channelFactory = new XdsChannelFactory() { - @Override - XdsChannel createChannel(List servers) { - ServerInfo serverInfo = Iterables.getOnlyElement(servers); - assertThat(serverInfo.getServerUri()).isEqualTo(serverName); - assertThat(serverInfo.getChannelCredentials()).isEmpty(); - return new XdsChannel(channel, /* useProtocolV3= */ true); - } - }; - xdsClient = new XdsClientImpl( TARGET_AUTHORITY, - servers, - channelFactory, + new XdsChannel(channel, /* useProtocolV3= */ true), EnvoyProtoData.Node.newBuilder().build(), syncContext, fakeClock.getScheduledExecutorService(), diff --git a/xds/src/test/java/io/grpc/xds/XdsClientImplTestForListener.java b/xds/src/test/java/io/grpc/xds/XdsClientImplTestForListener.java index ba729f04816..099950b123c 100644 --- a/xds/src/test/java/io/grpc/xds/XdsClientImplTestForListener.java +++ b/xds/src/test/java/io/grpc/xds/XdsClientImplTestForListener.java @@ -64,15 +64,12 @@ import io.grpc.internal.FakeClock.TaskFilter; import io.grpc.stub.StreamObserver; import io.grpc.testing.GrpcCleanupRule; -import io.grpc.xds.Bootstrapper.ChannelCreds; -import io.grpc.xds.Bootstrapper.ServerInfo; import io.grpc.xds.EnvoyProtoData.Address; import io.grpc.xds.EnvoyProtoData.Node; import io.grpc.xds.XdsClient.ConfigWatcher; import io.grpc.xds.XdsClient.ListenerUpdate; import io.grpc.xds.XdsClient.ListenerWatcher; import io.grpc.xds.XdsClient.XdsChannel; -import io.grpc.xds.XdsClient.XdsChannelFactory; import io.grpc.xds.internal.sds.CommonTlsContextTestsUtil; import java.io.IOException; import java.util.ArrayDeque; @@ -200,21 +197,9 @@ public void cancelled(Context context) { channel = cleanupRule.register(InProcessChannelBuilder.forName(serverName).directExecutor().build()); - List servers = - ImmutableList.of(new ServerInfo(serverName, ImmutableList.of(), null)); - XdsChannelFactory channelFactory = new XdsChannelFactory() { - @Override - XdsChannel createChannel(List servers) { - ServerInfo serverInfo = Iterables.getOnlyElement(servers); - assertThat(serverInfo.getServerUri()).isEqualTo(serverName); - assertThat(serverInfo.getChannelCredentials()).isEmpty(); - return new XdsChannel(channel, false); - } - }; - xdsClient = - new XdsClientImpl("", servers, channelFactory, NODE, syncContext, - fakeClock.getScheduledExecutorService(), backoffPolicyProvider, + new XdsClientImpl("", new XdsChannel(channel, /* useProtocolV3= */ false), NODE, + syncContext, fakeClock.getScheduledExecutorService(), backoffPolicyProvider, fakeClock.getStopwatchSupplier()); // Only the connection to management server is established, no RPC request is sent until at // least one watcher is registered. diff --git a/xds/src/test/java/io/grpc/xds/XdsClientImplTestV2.java b/xds/src/test/java/io/grpc/xds/XdsClientImplTestV2.java index d3691a9a475..09366b381c5 100644 --- a/xds/src/test/java/io/grpc/xds/XdsClientImplTestV2.java +++ b/xds/src/test/java/io/grpc/xds/XdsClientImplTestV2.java @@ -86,8 +86,6 @@ import io.grpc.internal.FakeClock.TaskFilter; import io.grpc.stub.StreamObserver; import io.grpc.testing.GrpcCleanupRule; -import io.grpc.xds.Bootstrapper.ChannelCreds; -import io.grpc.xds.Bootstrapper.ServerInfo; import io.grpc.xds.EnvoyProtoData.DropOverload; import io.grpc.xds.EnvoyProtoData.LbEndpoint; import io.grpc.xds.EnvoyProtoData.Locality; @@ -100,7 +98,6 @@ import io.grpc.xds.XdsClient.EndpointUpdate; import io.grpc.xds.XdsClient.EndpointWatcher; import io.grpc.xds.XdsClient.XdsChannel; -import io.grpc.xds.XdsClient.XdsChannelFactory; import io.grpc.xds.XdsClientImpl.MessagePrinter; import java.io.IOException; import java.util.ArrayDeque; @@ -278,23 +275,10 @@ public void cancelled(Context context) { channel = cleanupRule.register(InProcessChannelBuilder.forName(serverName).directExecutor().build()); - List servers = - ImmutableList.of(new ServerInfo(serverName, ImmutableList.of(), null)); - XdsChannelFactory channelFactory = new XdsChannelFactory() { - @Override - XdsChannel createChannel(List servers) { - ServerInfo serverInfo = Iterables.getOnlyElement(servers); - assertThat(serverInfo.getServerUri()).isEqualTo(serverName); - assertThat(serverInfo.getChannelCredentials()).isEmpty(); - return new XdsChannel(channel, false); - } - }; - xdsClient = new XdsClientImpl( TARGET_AUTHORITY, - servers, - channelFactory, + new XdsChannel(channel, /* useProtocolV3= */ false), Node.newBuilder().build(), syncContext, fakeClock.getScheduledExecutorService(),